Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Functions Kotlin to strict API #6386

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Migrate Functions Kotlin to strict API #6386

merged 3 commits into from
Oct 15, 2024

Conversation

emilypgoogle
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Javadoc Changes: 
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallOptions.Companion.html	2024-10-15 19:31:27.777883982 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallOptions.Companion.html	1970-01-01 00:00:00.000000000 +0000
@@ -1,16 +0,0 @@
-<html devsite="true">
-  <head>
-    <title>HttpsCallOptions.Companion</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/android/_reference-head-tags.html" %}
-  </head>
-  <body>
-    <div id="metadata-info-block"></div>
-    <h1>HttpsCallOptions.Companion</h1>
-    <p>
-      <pre>public static class <a href="/docs/reference/android/com/google/firebase/functions/HttpsCallOptions.Companion.html">HttpsCallOptions.Companion</a></pre>
-    </p>
-    <hr>
-  </body>
-</html>
-
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallOptions.html	2024-10-15 19:31:27.781884000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallOptions.html	2024-10-15 19:28:52.809025290 +0000
@@ -21,26 +21,6 @@
         </colgroup>
         <thead>
           <tr>
-            <th colspan="100%"><h3>Nested types</h3></th>
-          </tr>
-        </thead>
-        <tbody class="list">
-          <tr>
-            <td>
-              <div><code>public static class <a href="/docs/reference/android/com/google/firebase/functions/HttpsCallOptions.Companion.html">HttpsCallOptions.Companion</a></code></div>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <thead>
-          <tr>
             <th colspan="100%"><h3>Public fields</h3></th>
           </tr>
         </thead>

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v4.0

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

daymxn
daymxn approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For auditing sake, I'll leave b/369383096 here- which is a tracking task for doing this for all SDKS.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Test Results

20 files   -  58  20 suites   - 58   32s ⏱️ - 1m 18s
23 tests  - 283  23 ✅  - 283  0 💤 ±0  0 ❌ ±0 
68 runs   - 544  68 ✅  - 544  0 💤 ±0  0 ❌ ±0 

Results for commit 3011274. ± Comparison against base commit c50a9b5.

This pull request removes 306 and adds 23 tests. Note that renamed tests count towards both. 
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-functions:
error: Removed field com.google.firebase.functions.HttpsCallOptions.Companion [RemovedField]
error: Removed class com.google.firebase.functions.HttpsCallOptions.Companion [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-functions:
error: Removed field com.google.firebase.functions.HttpsCallOptions.Companion [RemovedField]
error: Removed class com.google.firebase.functions.HttpsCallOptions.Companion [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@emilypgoogle emilypgoogle merged commit 2dd9beb into main Oct 15, 2024
29 of 30 checks passed
@emilypgoogle emilypgoogle deleted the ep/functions-strict-api branch October 15, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daymxn daymxn daymxn approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilypgoogle @google-oss-bot @daymxn